Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused codeGenGlobs #21438

Merged
merged 5 commits into from
May 12, 2022
Merged

chore: remove unused codeGenGlobs #21438

merged 5 commits into from
May 12, 2022

Conversation

ZachJW34
Copy link
Contributor

User facing changelog

n/a

Additional details

Removing unused code I stumbled across related to "create-from-component" code gen.

How has the user experience changed?

n/a

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested a review from tgriesser as a code owner May 11, 2022 16:00
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 11, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented May 11, 2022 •
edited
Loading


Test summary

37672 • 2 • 464 • 0 • Flakiness 11

Run details
Project cypress
Status Failed
Commit 7974ca3
Started May 12, 2022 10:32 PM
Ended May 12, 2022 10:55 PM
Duration 22:52 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

Run group: 5x-driver-firefox-experimentalSessionAndOrigin (Linux, Firefox )
e2e/origin/commands/viewport.cy.ts 1 Failed
1 ... > syncs the viewport across multiple origins
Run group: 5x-driver-electron (Linux, Electron )
cypress/proxy-logging.cy.ts 1 Failed
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first

Flakiness

cypress/proxy-logging.cy.ts 2 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
2 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps
commands/files.cy.js 1 Flakiness
1 ... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding
commands/net_stubbing.cy.ts 1 Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
e2e/origin/commands/actions.cy.ts 1 Flakiness
1 cy.origin actions > #consoleProps > .submit()
This comment includes only the first 5 flaky tests. See all 11 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tbiethman
tbiethman approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@tbiethman tbiethman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like guessFramework is still being stubbed somewhere and failing a few unit tests. This should be good to go with a green build tho 👍

@ZachJW34
Copy link
Contributor Author

@tbiethman thanks for finding that. More stuff to remove!

@ZachJW34 ZachJW34 merged commit df3ca15 into 10.0-release May 12, 2022
@ZachJW34 ZachJW34 deleted the zachw/cleanup-unused-codegen-globs branch May 12, 2022 22:45
tgriesser added a commit that referenced this pull request May 13, 2022
@tgriesser
Merge branch '10.0-release' into tgriesser/feat/remoteField-stitching
7383e79 
* 10.0-release: (22 commits)
  fix: migrate multiples projects when in global mode (#21458)
  test: fix flaky cy-in-cy selector validity test (#21360)
  chore: remove unused codeGenGlobs (#21438)
  fix: use correct path for scaffolding spec on CT (#21411)
  fix: remove breaking options from testing type on migration (#21437)
  fix: test-recording instructions in Component Test mode (#21422)
  feat: distinguish app vs launchpad utm_source when using utm params (#21424)
  chore: update stubbed cloud types (#21451)
  chore: change to yarn registry
  fix(sessions): refactor flows, fix grouping bugs and align validation fail text (#21379)
  chore(sessions): more driver tests (#21378)
  chore: rename domain_fn to origin_fn (#21413)
  chore: release 9.6.1 (#21404)
  fix: ensure that proxy logs are updated after the xhr has actually completed (#21373)
  chore: Re-organize tests in assertions_spec.js (#21283)
  chore: Distribute tests to desktop-gui containers. Make `desktop-gui` tests faster! (#21305)
  chore(sessions): add additional tests (#21338)
  fix: Allow submit button to be outside of the form for implicit submission (#21279)
  fix(launcher): support Firefox as a snap (#21328)
  chore(sessions): break out sessions manager code and add unit tests (#21268)
  ...
astone123 added a commit that referenced this pull request Jul 21, 2022
@astone123
Revert "chore: remove unused codeGenGlobs (#21438)"
7dbb92b 
This reverts commit df3ca15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgriesser tgriesser tgriesser approved these changes

@tbiethman tbiethman tbiethman approved these changes

@marktnoonan marktnoonan Awaiting requested review from marktnoonan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZachJW34 @tgriesser @tbiethman