fix: pass family parameter to connect method #21545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insane-developer
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
|
|
jennifer-shehane
previously requested changes
May 18, 2022
There was a problem hiding this comment.
@insane-developer Could you please sign our CLA? We can’t accept any PRs without this signed.
jennifer-shehane
dismissed
their stale review
Dismissing my previous review as addressed
flotwig
approved these changes
May 23, 2022
There was a problem hiding this comment.
Looks good to me @insane-developer. We try to use 127.0.0.1 as much as possible to avoid bugs like this, but this is a much better fix.
ryanthemanuel
approved these changes
May 25, 2022
tgriesser
added a commit
that referenced
this pull request
May 25, 2022
…ess into tgriesser/fix/UNIFY-1408 * 'tgriesser/fix/UNIFY-1408' of github.com:cypress-io/cypress: fix: pass family parameter to connect method (#21545) chore: clean up `debug` statements in preparation for 10.0 release, add `debug` docs (#21621) chore: add regression test for ts detection (#21578)
tgriesser
added a commit
that referenced
this pull request
May 27, 2022
…pack * develop: fix: UNIFY-1408, warnings should be nested appropriately & clearable (#21630) chore: fix unit-tests-release job (#21652) chore(deps): update dependency eventsource to v2 [security] (#21639) fix: Add hover states for test titles in reporter (#21635) docs(CONTRIBUTING): Fix link to "good first issue" for newcomers (#21614) chore: compare `cy.screenshot` images in percy (#21598) fix: switching from ct to e2e (non-configured) does not go through setup (#21607) fix: issue with compilation failures in component testing (#21599) test: fix flaky launchpad test (#21637) docs: remove gitter link in contributing guide. (#21592) fix: order projects by most recently opened (#21589) fix: prevent crash on runs visit when offline (#21618) fix: pass family parameter to connect method (#21545) chore: clean up `debug` statements in preparation for 10.0 release, add `debug` docs (#21621) chore: add regression test for ts detection (#21578)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
family: 4explicitly forces Socket.connect to use ipv4 address.Without this change Socket.connect may use ipv6 address which whould lead to error due to the explicit use of
127.0.0.1here.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?