fix: Add hover states for test titles in reporter #21635
Conversation
|
Thanks for taking the time to open a PR!
|
BlueWinds
requested review from
jennifer-shehane,
marktnoonan and
a team
and removed request for
a team and
jennifer-shehane
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Changes look great, but we need create a new |
|
|
||
| import '../../src/main.scss' | ||
|
|
||
| Cypress.Commands.add('mount', mount) |
There was a problem hiding this comment.
You mentioned in slack there was an issue with
declare global {
namespace Cypress {
interface Chainable {
mount: typeof mount
}
}
}
I added this and included cypress/support/component.ts in the tsconfig and everything compiled fine, plus it removed some of the ts warnings.
There was a problem hiding this comment.
The issue with that was because I wasn't using our webpack configs (and therefor everything was broken, that just being one example). I'll add the type addition back in.
circle.yml
Outdated
| @@ -2324,6 +2340,11 @@ linux-workflow: &linux-workflow | |||
| percy: true | |||
| requires: | |||
| - build | |||
| - run-reporter-component-tests-chrome: | |||
| context: [test-runner:launchpad-tests, test-runner:percy] | |||
There was a problem hiding this comment.
I'm not super familiar with this setup, but I think you could:
- Use the
test-runner:cypress-record-keycontext here rather thantest-runner:launchpad-tests - Update
run-new-ui-teststo parameterize the CYPRESS_RECORD_KEY variable it uses (currently hardcoded to$TEST_LAUNCHPAD_RECORD_KEY, you want$MAIN_RECORD_KEYwith the cypress-record-key context)
That might get you passed the current errors and keep the existing reporter-integration-tests build recording as-is.
…ess into tgriesser/fix/UNIFY-1408 * 'tgriesser/fix/UNIFY-1408' of github.com:cypress-io/cypress: chore(deps): update dependency eventsource to v2 [security] (#21639) fix: Add hover states for test titles in reporter (#21635) docs(CONTRIBUTING): Fix link to "good first issue" for newcomers (#21614)
…pack * develop: fix: UNIFY-1408, warnings should be nested appropriately & clearable (#21630) chore: fix unit-tests-release job (#21652) chore(deps): update dependency eventsource to v2 [security] (#21639) fix: Add hover states for test titles in reporter (#21635) docs(CONTRIBUTING): Fix link to "good first issue" for newcomers (#21614) chore: compare `cy.screenshot` images in percy (#21598) fix: switching from ct to e2e (non-configured) does not go through setup (#21607) fix: issue with compilation failures in component testing (#21599) test: fix flaky launchpad test (#21637) docs: remove gitter link in contributing guide. (#21592) fix: order projects by most recently opened (#21589) fix: prevent crash on runs visit when offline (#21618) fix: pass family parameter to connect method (#21545) chore: clean up `debug` statements in preparation for 10.0 release, add `debug` docs (#21621) chore: add regression test for ts detection (#21578)
User facing changelog
Hovering over test names now highlights the row to indicate clickability. Unifies styles for hovering over test name / hook name / command name.
Additional details
Adds first component tests (primarily percy snapshots) to
packages/reporter.Steps to test
yarn devto recompile reporter css, otherwise you won't see the updates.cypress openany project.How has the user experience changed?
Old behavior:
New behavior:
PR Tasks
cypress-documentation?type definitions?