-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add hover states for test titles in reporter #21635
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
be7ab64
fix: Add hover states for test titles in reporter
BlueWinds 1019511
Add run-reporter-component-tests-chrome circle step
BlueWinds a4cc90d
Fix new reporter ct task; Add mount type annotation to reporter suppo…
BlueWinds f8935fd
One more try at proper circle configuration
BlueWinds 5b0917f
Get proper cypress record key for reporter component tests
BlueWinds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width,initial-scale=1.0"> | ||
<title>Components App</title> | ||
</head> | ||
<body> | ||
<div data-cy-root class="reporter" style="padding: 20px;"></div> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { mount } from 'cypress/react' | ||
import 'cypress-real-events/support' | ||
import { installCustomPercyCommand } from '@packages/ui-components/cypress/support/customPercyCommand' | ||
|
||
import '../../src/main.scss' | ||
|
||
Cypress.Commands.add('mount', mount) | ||
installCustomPercyCommand() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import React from 'react' | ||
import { Hook } from './hooks' | ||
|
||
import '../main.scss' | ||
|
||
describe('hooks/hooks.tsx', () => { | ||
it('should mount', () => { | ||
const model = { | ||
failed: false, | ||
hookName: 'TEST BODY', | ||
} | ||
|
||
cy.mount(<div className="runnable suite"> | ||
<div className="hooks-container"> | ||
<Hook model={model} showNumber={false} /> | ||
</div> | ||
</div>) | ||
|
||
cy.percySnapshot() | ||
|
||
cy.contains('TEST BODY').click().realHover() | ||
cy.percySnapshot() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import React from 'react' | ||
import Test from './test' | ||
|
||
describe('test/test.tsx', () => { | ||
it('should mount', () => { | ||
const model = { | ||
isOpen: false, | ||
level: 0, | ||
state: 'passed', | ||
title: 'foobar', | ||
attempts: [], | ||
} | ||
|
||
const appState = { | ||
studioActive: false, | ||
} | ||
|
||
cy.mount(<div className="runnable suite"> | ||
<Test model={model} appState={appState} /> | ||
</div>) | ||
|
||
cy.percySnapshot() | ||
|
||
cy.contains('foobar').click().realHover() | ||
cy.percySnapshot() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned in slack there was an issue with
I added this and included
cypress/support/component.ts
in the tsconfig and everything compiled fine, plus it removed some of the ts warnings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with that was because I wasn't using our webpack configs (and therefor everything was broken, that just being one example). I'll add the type addition back in.