-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable runner to be rebuilt with general watcher #21664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
AtofStryker
force-pushed
the
chore/enable-runner-rebuild-gulp
branch
from
May 27, 2022 17:51
ef7b832
to
32170b1
Compare
AtofStryker
changed the title
enable runner to be rebuild with general watcher
chore: enable runner to be rebuild with general watcher
May 27, 2022
AtofStryker
changed the title
chore: enable runner to be rebuild with general watcher
chore: enable runner to be rebuilt with general watcher
May 27, 2022
mschile
reviewed
May 27, 2022
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
AtofStryker
force-pushed
the
chore/enable-runner-rebuild-gulp
branch
from
May 27, 2022 18:40
32170b1
to
89611f0
Compare
mschile
approved these changes
May 27, 2022
mjhenkes
approved these changes
May 31, 2022
lmiller1990
approved these changes
Jun 2, 2022
Cool, hope we can drop runner/runner-ct and webpack in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
Tweaking the gulpfile to watch both the
runner-ct
andrunner
packages for whenyarn watch
is executed in the root directory. This way, when the driver is under development under current circumstances, live reloading of the test occurs to observe changes (including items in the cross origin injection)Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?