Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable runner to be rebuilt with general watcher #21664

Merged
merged 6 commits into from
Jun 2, 2022

Conversation

AtofStryker
Copy link
Contributor

  • Closes N/A

User facing changelog

Additional details

Tweaking the gulpfile to watch both the runner-ct and runner packages for when yarn watch is executed in the root directory. This way, when the driver is under development under current circumstances, live reloading of the test occurs to observe changes (including items in the cross origin injection)

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@AtofStryker AtofStryker requested review from mjhenkes, mschile and a team May 27, 2022 17:51
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 27, 2022

Thanks for taking the time to open a PR!

@AtofStryker AtofStryker force-pushed the chore/enable-runner-rebuild-gulp branch from ef7b832 to 32170b1 Compare May 27, 2022 17:51
@AtofStryker AtofStryker changed the title enable runner to be rebuild with general watcher chore: enable runner to be rebuild with general watcher May 27, 2022
@AtofStryker AtofStryker changed the title chore: enable runner to be rebuild with general watcher chore: enable runner to be rebuilt with general watcher May 27, 2022
scripts/gulp/gulpfile.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented May 27, 2022



Test summary

37537 0 454 0Flakiness 4


Run details

Project cypress
Status Passed
Commit f784b96
Started Jun 1, 2022 3:01 PM
Ended Jun 1, 2022 3:18 PM
Duration 16:31 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
next.cy.ts Flakiness
1 Working with next-12 > should detect new spec
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AtofStryker AtofStryker force-pushed the chore/enable-runner-rebuild-gulp branch from 32170b1 to 89611f0 Compare May 27, 2022 18:40
@AtofStryker AtofStryker requested a review from mschile May 27, 2022 18:40
@lmiller1990
Copy link
Contributor

Cool, hope we can drop runner/runner-ct and webpack in the future.

@lmiller1990 lmiller1990 merged commit 9cdab56 into develop Jun 2, 2022
@lmiller1990 lmiller1990 deleted the chore/enable-runner-rebuild-gulp branch June 2, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants