Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable runner to be rebuilt with general watcher #21664

Merged
merged 6 commits into from
Jun 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/gulp/gulpfile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { makePathMap } from './utils/makePathMap'
import { makePackage } from './tasks/gulpMakePackage'
import { exitAfterAll } from './tasks/gulpRegistry'
import { execSync } from 'child_process'
import { webpackRunner } from './tasks/gulpWebpack'
import { webpackRunner, webpackRunnerCT } from './tasks/gulpWebpack'
import { e2eTestScaffold, e2eTestScaffoldWatch } from './tasks/gulpE2ETestScaffold'
import dedent from 'dedent'

Expand Down Expand Up @@ -59,6 +59,7 @@ gulp.task(
'dev:watch',
gulp.parallel(
webpackRunner,
webpackRunnerCT,
gulp.series(
makePathMap,
// Before dev, fetch the latest "remote" schema from the Cypress dashboard
Expand Down
10 changes: 9 additions & 1 deletion scripts/gulp/tasks/gulpWebpack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,17 @@ import semver from 'semver'

type Env = typeof process.env

export function webpackRunner () {
export function webpackRunnerCT () {
return runWebpack({
cwd: monorepoPaths.pkgRunnerCt,
prefix: 'webpack:runner:ct',
args: ['-w'],
})
}

export function webpackRunner () {
return runWebpack({
cwd: monorepoPaths.pkgRunner,
prefix: 'webpack:runner',
args: ['-w'],
})
Expand Down