fix: partial fix for #21997 & #22004, throw the originalError #22009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
jennifer-shehane
requested review from
estrada9166
and removed request for
jennifer-shehane
estrada9166
approved these changes
Jun 1, 2022
ZachJW34
reviewed
Jun 1, 2022
npm/webpack-dev-server/package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "test-unit": "mocha -r ts-node/register/transpile-only --config ./test/.mocharc.js" | |||
| }, | |||
| "dependencies": { | |||
| "find-up": "6.3.0", | |||
| "find-up": "5.0.0", | |||
There was a problem hiding this comment.
Why did this need to be downgraded?
There was a problem hiding this comment.
I was thinking it was because 6.3.0 is ESM only, and webpack-dev-server is not an ESM project - though I guess we're using importModule so that shouldn't matter
…ss-io/cypress into tgriesser/fix/21997-fix-invalid-ts * 'tgriesser/fix/21997-fix-invalid-ts' of github.com:cypress-io/cypress: fix: scroll of inline specs list (#21994)
Co-authored-by: Zach Bloomquist <git@chary.us>
ZachJW34
approved these changes
Jun 1, 2022
npm/webpack-dev-server/package.json
Outdated
| @@ -46,4 +46,4 @@ | |||
| "files": [ | |||
| "dist" | |||
| ] | |||
| } | |||
| } | |||
tgriesser
commented
Jun 1, 2022
tgriesser
commented
Jun 1, 2022
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Throws the first error encountered when failing due to an esm import, when Node's ESM loading cannot not handle it. This will provide better information about the actual error encountered, such as when processed via
ts-nodefor TypeScript files.Additional details
Not the full fix for the issues, but will surface better warnings around the issue
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?