-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulated mouse fixes, rightclick, dblclick #3030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kuceb
force-pushed
the
issue-2957
branch
3 times, most recently
from
January 15, 2019 19:21
a3e9664
to
7db89d6
Compare
WIP going back on for dblclick and rightclick changes |
Changed the base to |
It's in a reviewable state, but I do still have one task to do |
# Conflicts: # packages/driver/src/cy/commands/screenshot.coffee # packages/driver/test/cypress/integration/dom/coordinates_spec.coffee # packages/driver/test/cypress/integration/e2e/dom_hitbox.spec.js
This was referenced Oct 11, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mouse events
mouse events added in this PR:
send mouseover event during click commands
fix click not firing mouseover event #2928
fix Cypress should fire 'mouseover' event on .click() #1847
fix clicking on an openlayers canvas doesn't trigger any events #1016
send pointer events (
pointerdown
,pointerup
,pointermove
) during click commandsfix click not firing pointer events #2957
fix Conversion to onPointerDown #2045
send mousemove events during click commands
fix No mousemove events before clicks #2521
add mouseout events
fix incorrect click coordinates inside [same domain] iframe
fix Cypress click coordinates incorrect when element inside Iframe #4347
right click, double click
dblclick
command to accept same options + perform actions similar toclick
fix cy.dblclick() should accept same options as cy.click() #116
fix dblclick() doesn't work as click() #3798
fix Map not responding to mouse commands #2768
fix Cypress's dblclick does not function the same way as a user double clicking #3224
fix Need a "rightclick" command #53
trigger
screenX
/screenY
properties to events sent with.trigger
fix trigger('mousemove', ...) yields undefined values for screenX and screenY in event handler #3187
tasks
sendbrowser already does this even when out of focusselectionchange
event ondocument
fromAutWindow
positional coords for red hitboxnon-blocking tasks
.click()
https://docs.cypress.io/api/commands/click.html#Events Update docs to reflect changes for click/doubleclick/mouse events cypress-documentation#2173.dblclick()
docoptions
to match.click()
options. https://docs.cypress.io/api/commands/dblclick.html#ArgumentsGuide for review
cy.click, cy.dblclick, and cy.rightclick
dblclick
andrightclick
User facing changes:
API:
cy.rightclick()
typedefs changes:
cy.rightclick()
typedefUX:
click
command has more information:warning messaging in table:
no mouse move events needed: