simulated mouse fixes, rightclick, dblclick

cli/types/index.d.ts

@@ -620,7 +620,14 @@ declare namespace Cypress {
      *
      * @see https://on.cypress.io/dblclick
      */
-    dblclick(options?: Partial<Loggable>): Chainable
+    dblclick(options?: Partial<ClickOptions>): Chainable<Subject>
+
+    /**
+     * Right-click a DOM element.
+     *
+     * @see https://on.cypress.io/rightclick
+     */
+    rightclick(options?: Partial<ClickOptions>): Chainable<Subject>
 
     /**
      * Set a debugger and log what the previous command yields.

cli/types/tests/chainer-examples.ts

@@ -452,3 +452,7 @@ cy.writeFile('../file.path', '', {
   flag: 'a+',
   encoding: 'utf-8'
 })
+
+cy.get('foo').click()
+cy.get('foo').rightclick()
+cy.get('foo').dblclick()

packages/driver/src/cy/actionability.coffee

@@ -36,19 +36,19 @@ getPositionFromArguments = (positionOrX, y, options) ->
 
   return {options, position, x, y}
 
-ensureElIsNotCovered = (cy, win, $el, fromViewport, options, log, onScroll) ->
+ensureElIsNotCovered = (cy, win, $el, fromElViewport, options, log, onScroll) ->
   $elAtCoords = null
 
-  getElementAtPointFromViewport = (fromViewport) ->
+  getElementAtPointFromViewport = (fromElViewport) ->
     ## get the element at point from the viewport based
     ## on the desired x/y normalized coordinations
-    if elAtCoords = $dom.getElementAtPointFromViewport(win.document, fromViewport.x, fromViewport.y)
+    if elAtCoords = $dom.getElementAtPointFromViewport(win.document, fromElViewport.x, fromElViewport.y)
       $elAtCoords = $dom.wrap(elAtCoords)
 
-  ensureDescendents = (fromViewport) ->
+  ensureDescendents = (fromElViewport) ->
     ## figure out the deepest element we are about to interact
     ## with at these coordinates
-    $elAtCoords = getElementAtPointFromViewport(fromViewport)
+    $elAtCoords = getElementAtPointFromViewport(fromElViewport)
 
     cy.ensureElDoesNotHaveCSS($el, 'pointer-events', 'none', log)
     cy.ensureDescendents($el, $elAtCoords, log)
@@ -57,8 +57,8 @@ ensureElIsNotCovered = (cy, win, $el, fromViewport, options, log, onScroll) ->
 
   ensureDescendentsAndScroll = ->
     try
-      ## use the initial coords fromViewport
-      ensureDescendents(fromViewport)
+      ## use the initial coords fromElViewport
+      ensureDescendents(fromElViewport)
     catch err
       ## if we're being covered by a fixed position element then
       ## we're going to attempt to continously scroll the element
@@ -146,16 +146,16 @@ ensureElIsNotCovered = (cy, win, $el, fromViewport, options, log, onScroll) ->
               ## now that we've changed scroll positions
               ## we must recalculate whether this element is covered
               ## since the element's top / left positions change.
-              fromViewport = getCoordinatesForEl(cy, $el, options).fromViewport
+              fromElViewport = getCoordinatesForEl(cy, $el, options).fromElViewport
 
               ## this is a relative calculation based on the viewport
               ## so these are the only coordinates we care about
-              ensureDescendents(fromViewport)
+              ensureDescendents(fromElViewport)
             catch err
               ## we failed here, but before scrolling the next container
               ## we need to first verify that the element covering up
               ## is the same one as before our scroll
-              if $elAtCoords = getElementAtPointFromViewport(fromViewport)
+              if $elAtCoords = getElementAtPointFromViewport(fromElViewport)
                 ## get the fixed element again
                 $fixed = getFixedOrStickyEl($elAtCoords)
 
@@ -201,7 +201,7 @@ ensureNotAnimating = (cy, $el, coordsHistory, animationDistanceThreshold) ->
   ## if we dont have at least 2 points
   ## then automatically retry
   if coordsHistory.length < 2
-    throw new Error("coordsHistory must be at least 2 sets of coords")
+    throw $utils.cypressErr("coordsHistory must be at least 2 sets of coords")
 
   ## verify that our element is not currently animating
   ## by verifying it is still at the same coordinates within
@@ -277,16 +277,16 @@ verify = (cy, $el, options, callbacks) ->
         ## (see https://github.com/cypress-io/cypress/pull/1478)
 
         sticky = !!getStickyEl($el)
-        coordsHistory.push(if sticky then coords.fromViewport else coords.fromWindow)
+        coordsHistory.push(if sticky then coords.fromElViewport else coords.fromElWindow)
 
         ## then we ensure the element isnt animating
         ensureNotAnimating(cy, $el, coordsHistory, options.animationDistanceThreshold)
 
         ## now that we know our element isn't animating its time
         ## to figure out if its being covered by another element.
         ## this calculation is relative from the viewport so we
-        ## only care about fromViewport coords
-        $elAtCoords = options.ensure.notCovered && ensureElIsNotCovered(cy, win, $el, coords.fromViewport, options, _log, onScroll)
+        ## only care about fromElViewport coords
+        $elAtCoords = options.ensure.notCovered && ensureElIsNotCovered(cy, win, $el, coords.fromElViewport, options, _log, onScroll)
 
       ## pass our final object into onReady
       finalEl = $elAtCoords ? $el