Improved proxy support #3531
Merged
Improved proxy support #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
force-pushed
the
issue-1469-proxies
branch
from
fe12a1f
to
065f51c
Compare
10 tasks
|
Added some visual indicators to desktop-gui. Kinda feel like these proxy settings should be part of an app-wide "preferences" window, like how it is in Postman. They're a little out of place in Project Settings. Visuals (outdated)On Linux with some proxy environment vars set:
On Windows with some proxy registry settings:
With no proxy settings:
|
…uns tab work behind a proxy
Revert "extension: force proxy [wip]" This reverts commit 3ab6ba4.
flotwig
force-pushed
the
issue-1469-proxies
branch
from
5da02e9
to
4ffc140
Compare
|
These are awesome, @flotwig! |
Liu233w
pushed a commit
to Liu233w/acm-statistics
that referenced
this pull request
Mar 31, 2019
因为cypress对于 proxy 的支持还不大够，等到 cypress-io/cypress#3531 合并之后应该就可以了
Liu233w
pushed a commit
to Liu233w/acm-statistics
that referenced
this pull request
Mar 31, 2019
因为cypress对于 proxy 的支持还不大够，等到 cypress-io/cypress#3531 合并之后应该就可以了
brian-mann
approved these changes
Apr 1, 2019
This was referenced Apr 1, 2019
This was referenced Apr 1, 2019
|
@brian-mann @flotwig Great work on this PR, I'm Just wondering if you had a timeline of when this will be released. The changes made are critical to users like me sitting behind a corporate firewall. I'm currently facing a lot of issues running Cypress behind a corporate firewall so I'm hoping this will help address them. Once again great work guys and thank you for this awesome tool 👍 |
|
@RicardoVaranda We're working on releasing this as soon as possible. We've already written up most of the changelog. |
probot-auto-merge bot
pushed a commit
to Liu233w/acm-statistics
that referenced
this pull request
Apr 1, 2019
因为cypress对于 proxy 的支持还不大够，等到 cypress-io/cypress#3531 合并之后应该就可以了
|
echoing @RicardoVaranda great work on this @flotwig and I'm excited to be able to use Cypress at my day job finally :-) |
|
I concur, I've been wanting to use Cypress in our company for a while, now it might finally happen. Great work. |
Closed
|
Yes!!! Please release! :))) |
|
We're working on releasing. We noticed a regression and also some unexpected size increase before officially releasing. Just trying to prevent a release + insta-patch release. 😄 |
This was referenced Apr 24, 2019
laurinenas
pushed a commit
to laurinenas/cypress
that referenced
this pull request
Apr 28, 2019
* https-proxy: unused file * server: wrap all https requests that use a proxy * server: use request lib in ensureUrl if proxy is in use. this makes runs tab work behind a proxy * electron: pass --proxy-server to app itself, so the embedded github login page works * cli: first attempt at env vars from windows registry * cli: api cleanup * cli: lint * cli: fix crash on no proxy, add tests * add desktop-gui watch to terminals.json * cli: pass along --proxy-source * electron: pass --proxy-bypass-list too * server: whitelist proxy* args * cli: better wording * desktop-gui: display proxy settings * extension: force proxy [wip] * extension: finally, i am victorious over coffeescript * extension: add -loopback to bypasslist * extension: revert changes Revert "extension: force proxy [wip]" This reverts commit 3ab6ba4. * desktop-gui: skip proxysettings if there aren't any * https-proxy, server: proxy directConnections using https-proxy-agent * https-agent: pool httpsAgents * https-proxy: work when they're not on a proxy * https-proxy: ci - use agent 1.0 * https-proxy: tests * desktop-gui: hide proxy settings when not using proxy * https-proxy: pass req through to https-proxy-agent callback * cli: use get-windows-proxy * desktop-gui: always show proxy settings * server: use get-windows-proxy * electron, server: supply electron proxy config when window launched * server: fix * https-proxy: cleanup * server: clean up ensureUrl * https-proxy: cleanup * cli: fix * cli: fix destructuring * server: enable ForeverAgent to pool HTTPS/HTTP connections cypress-io#3192 * server: updating snapshot * https-proxy: don't crash, do error if proxy unreachable * https-proxy: * get-windows-proxy@1.0.0 * https-proxy: use proxy-from-env to decide on a proxy for a url * server: fallback to HTTP_PROXY globally if HTTPS_PROXY not set * server: proxy args test * cli: add proxy tests * cli: add test that loadSystemProxySettings is called during download * cli, server: account for the fact that CI has some proxy vars set * https-proxy: "" * cli, https-proxy, server: "" * desktop-gui: update settings gui * desktop-gui: cypress tests for proxy settings * server: strict undefined check * cli, server: move get-windows-proxy to scope, optionalDeps * server, cli: use new and improved get-windows-proxy * cli, server: 1.5.0 * server: re-check for proxy since cli may have failed to load the lib * server, cli: 1.5.1 * server: NO_PROXY=localhost by default, clean up * https-proxy: disable Nagle's on proxy sockets \cypress-io#3192 * https-proxy: use setNoDelay on upstream, cache https agent * https-proxy: test basic auth * https-proxy: add todo: remove this * server: add custom HTTP(s) Agent implementation w keepalive, tunneling * server: typescript for agent * add ts to zunder * server: more ts * ts: add missing Agent type declaration * server: create CombinedAgent * server: use agent in more places * ts: more declarations * server: make script work even if debug port not supplied * server: begin some testing * server, ts: agent, tests * server: test * server: agent works with websockets now * server: update snapshot * server: work out some more bugs with websockets * server: more websockets * server: add net_profiler * https-proxy: fix dangling socket on direct connection * server: fix potential 'headers have already been sent' * https-proxy: nab another dangler * server: update test to expect agent * https-proxy: fix failing test * desktop-gui: change on-link * server: add tests for empty response case * server: tests * server: send keep-alive with requests * server: make net profiler hook on socket.connect * server: only hook profiler once * server: update tests, add keep-alive test * server: only regen headers if needed * server: move http_overrides into CombinedAgent, make it proxy-proof for cypress-io#112 * server: update snapshot * server: undo * server: avoid circular dependency * https-proxy, server: use our Agent instead of https-proxy-agent * server: add dependency back * cli: actually use proxy for download * server, launcher, ts: typescript * Revert "server, launcher, ts: typescript" This reverts commit d3f8b8b. * Revert "Revert "server, launcher, ts: typescript"" This reverts commit 818dfdf. * ts, server: respond to PR * server, ts: types * ts: really fix types * https-proxy, server: export CA from https-proxy * agent, server, https-proxy: move agent to own package * agent => networking, move connect into networking * fix tests * fix test * networking: respond to PR changes, add more unit tests * rename ctx * networking, ts: add more tests * server: add ensureUrl tests * https-proxy: remove https-proxy-agent * server: use CombinedAgent for API * server: updates * add proxy performance tests * add perf tests to workflow * circle * run perf tests with --no-sandbox * networking, ts: ch-ch-ch-ch-changes * server, networking: pr changes * run networking tests in circle * server: fix performance test * https-proxy: test that sockets are being closed * https-proxy: write, not emit * networking: fix test * networking: bubble err in connect * networking: style * networking: clean p connect error handling * networking => network * server: make perf tests really work * server: really report * server: use args from browser * server: use AI to determine max run time * server: load electron only when needed Co-authored-by: Brian Mann <brian@cypress.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1469
Fixes #1312
ensureUrlfailure (potentially due to corporate proxy usage) #1541Connection: closeheaders not usingConnection: keep-aliveon http requests - fixes Keep-alive connections over http #3857try to find a way to override ProxyModegonna skip this for now - https://www.chromium.org/administrators/policy-list-3#ProxyMode - Cypress fails if ProxyMode Chrome policy is present #1253Chrome extension- doesn't work, registry overrides itNPAPI extension- jk, this has been completely removed from Chrome >42PPAPI plugin- can only modify proxy for a Chrome App, and both chrome apps and PPAPI are being deprecatedautoload OS X system proxy settings?