Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent EISDIR when trying to load directories as fixtures #3740

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Prevent EISDIR when trying to load directories as fixtures #3740

merged 3 commits into from
Apr 1, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 18, 2019

Fixes #3739

@flotwig flotwig changed the title [WIP] Prevent trying to load directories as fixtures [WIP] Prevent EISDIR when trying to load directories as fixtures Mar 18, 2019
@flotwig flotwig changed the title [WIP] Prevent EISDIR when trying to load directories as fixtures Prevent EISDIR when trying to load directories as fixtures Mar 18, 2019
@flotwig flotwig requested a review from brian-mann March 18, 2019 17:52
@jennifer-shehane jennifer-shehane requested a review from a team March 19, 2019 04:50
jennifer-shehane
jennifer-shehane approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested manually with the Dashboard tests that were previously failing - looks good.

You may want a more proper code review though - I just scanned it.

@jennifer-shehane jennifer-shehane requested a review from a team March 19, 2019 04:58
@brian-mann brian-mann merged commit 3ce1aec into develop Apr 1, 2019
@cypress-bot cypress-bot bot mentioned this pull request Apr 1, 2019
Closed
laurinenas pushed a commit to laurinenas/cypress that referenced this pull request Apr 28, 2019
@flotwig @laurinenas
Prevent EISDIR when trying to load directories as fixtures (cypress-i…
b28a5a2 
…o#3740)

* server: prevent trying to load directories as fixtures
@flotwig flotwig deleted the issue-3739-fix-fixtures branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flotwig @jennifer-shehane @brian-mann