Correct detection logic for Edge & Firefox Nightly

[YOU54F]

Correct detection logic for Edge & Firefox Nightly on MacOSX

• Closes MacOS not detecting Microsoft Edge as a launch-able browser #6354
• Closes Firefox Nightly - no version found #6345

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[bahmutov]

Checked Edge variants (from https://www.microsoftedgeinsider.com/en-us/download) on Mac - this PR fixes the detection.

and prints correct information when doing node packages/launcher/index.js

[flotwig]

As part of this PR, should we order the editions Stable => Beta => Dev => Canary, so it goes most stable => least stable?

[bahmutov]

Checked Firefox Nightly and Dev on Mac (from https://www.mozilla.org/en-US/firefox/channel/desktop/) - correct detection

[bahmutov]

@flotwig I really like your test in #6367 but it is hard to push changes to external patch PR

So I think we can: land your PR. Then land this PR. Then add tests for Edge on Mac, and then think how to order browsers - I say order by name, major

[YOU54F]

Feel free just to copy changes into @flotwig ‘s pr. I am not precious about it being from this PR

[bahmutov]

Thank you @YOU54F , you are the best. @flotwig can you copy this commit into your PR and close 3 issues at once? And order Edges too

[YOU54F]

Woop woop! Job’s a good un. Firefox support looks so good guys, all my work tests passed first time with exception to that that require web security disabled. Will see if I can find a workaround as per chrome, when I get some time. Thanks for all the hard work as usual

[bahmutov]

@YOU54F one other thing you can do - skip those tests on firefox selectively https://github.com/cypress-io/cypress-skip-test#imports-with-callback

[YOU54F]

@YOU54F one other thing you can do - skip those tests on firefox selectively https://github.com/cypress-io/cypress-skip-test#imports-with-callback

Sweet, that looks really nice! For now, I invoke a single smoke test that goes through our entire journey with chromewebsecurity off and with ignore x frame headers extension in a seperate invocation of cypress and all our other tests run with the normal configuration so not an issue for now, but that is good to know 👌