Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect 64-bit Firefox on Windows #6367

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Detect 64-bit Firefox on Windows #6367

merged 3 commits into from
Feb 7, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 7, 2020 •
edited
Loading

User facing changelog

  • Added 64-bit Firefox paths to Windows browser detection. 64-bit Firefox will now be detected correctly on Windows.

Additional details

  • also added tests for windows browser launcher, because there were none 😄
  • manually validated on winodws

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 7, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@flotwig
Copy link
Contributor Author

flotwig commented Feb 7, 2020

there we go:
image

@cypress
Copy link

cypress bot commented Feb 7, 2020 •
edited
Loading


Test summary

6863 • 0 • 97 • 0

Run details
Project cypress
Status Passed
Commit aececa6
Started Feb 7, 2020 6:21 PM
Ended Feb 7, 2020 6:27 PM
Duration 06:28 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title [WIP] Detect 64-bit Firefox on Windows Detect 64-bit Firefox on Windows Feb 7, 2020
@flotwig flotwig requested review from a team, chrisbreiding and brian-mann and removed request for a team, chrisbreiding and brian-mann February 7, 2020 18:16
@bahmutov bahmutov mentioned this pull request Feb 7, 2020
Merged
5 tasks
bahmutov
bahmutov reviewed Feb 7, 2020
View reviewed changes
packages/launcher/__snapshots__/spec.ts.js
"family": "chromium",
"channel": "stable",
"displayName": "Chrome",
"versionRegex": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is major version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that gets added later on down the line, in the generic detection code, which is tested elsewhere

bahmutov
bahmutov reviewed Feb 7, 2020
View reviewed changes
packages/launcher/lib/windows/index.ts
return normalize(exe)
function getFirefoxPaths (editionFolder) {
return () => {
return (['Program Files', 'Program Files (x86)'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be possible to install 32 and 64 bit Firefox - and then both will be detected and have same name and version and everything?

Copy link
Contributor Author

@flotwig flotwig Feb 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and no, 64-bit firefox will be preferred over 32-bit firefox (if both are installed)

this would be an exceptional case, though - in my tests, installing 32-bit will uninstall the 64-bit version, and vice versa. so they'd really have to be doin somethin crazy to run into this.

bahmutov
bahmutov approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the best PR since 4.0.0

@flotwig flotwig merged commit 8fb27e1 into develop Feb 7, 2020
@cypress-bot cypress-bot bot mentioned this pull request Feb 7, 2020
Closed
@flotwig flotwig deleted the issue-6355-win-ff-x64 branch January 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cypress does not detect Firefox 64-bit browser
2 participants
@flotwig @bahmutov