fix rerun before/after hooks on top navigation

[kuceb]

• fix Code in hooks and test are rerun when changing to a different superdomain #1987
• fix Exception in root level after() doesn't fail test run in interactive mode #2296 failure in root after hook doesn't show failure in browser reporter
• address Cypress runs commands twice when no baseUrl defined #2777 (fixes half of the problem - where hooks are rerun on navigation)

User facing changelog

• Bug fix: We no longer rerun before/after hooks of already ran suites on domain navigation

Additional details

How has the user experience changed?

PR Tasks

• rename duplicate issue number
• add testcase for navigation inside suite
• this introduced another bug due to other broken behavior in cypress related to global hooks, so this currently skips global after hooks after navigation - add small exclusion for this edge case

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

7185 • 0 • 98 • 0

---

Run details

Project	cypress
Status	Passed
Commit	f10a042
Started	Apr 23, 2020 9:18 AM
Ended	Apr 23, 2020 9:24 AM
Duration	06:00 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

This does address the issue of before hooks running multiple times when navigating to a different cross-domain across separate tests. (I actually wasn't able to replicate this happening with after hooks before this fix).

This does not address #2777 which is the before hook running twice when there is no baseUrl, so it navigates to our localhost:randomport - runs before hook, then redirects to the url under cy.visit() and runs the before hook again. Not sure if that is important for you to address to move forward with your other work.

[kuceb]

Well, I clicked the update branch button and it looks like it merged it instead

[chrisbreiding]

Does this also fix #3904?

[jennifer-shehane]

New PR to follow is here: #7154