fix rerun before/after hooks on navigation [remerge]

[kuceb]

prev PR accidentally merged #7035

• fix Code in hooks and test are rerun when changing to a different superdomain #1987
• fix Exception in root level after() doesn't fail test run in interactive mode #2296 failure in root after hook doesn't show failure in browser reporter
• address Cypress runs commands twice when no baseUrl defined #2777 (fixes half of the problem - where hooks are rerun on navigation)

User facing changelog

• Bug fix: on domain navigation, before/after hooks defined in completed suites no longer erroneously rerun
• Bug fix: command logs from root after hooks are now displayed on the correct test

Additional details

How has the user experience changed?

Before: Errors in root after hooks wouldn't fail test

After: Errors in root after hooks fail test

Tasks

• cleanup
• wait for merge remove Cypress object proxying related code for certain utils #7486

PR Tasks

• rename duplicate issue number
• add testcase for navigation inside suite
• this introduced another bug due to other broken behavior in cypress related to global hooks, so this currently skips global after hooks after navigation - add small exclusion for this edge case
• remove an old conditional around predicting when the last afterhook has fired, which fixes the hook firing order bug

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

7701 • 0 • 112 • 0

---

Run details

Project	cypress
Status	Passed
Commit	ea8142c
Started	May 27, 2020 11:45 PM
Ended	May 27, 2020 11:52 PM
Duration	07:07 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

I manually confirmed this fixes the issues mentioned.

[jennifer-shehane]

@chrisbreiding was asking #7035 (comment)

Does this also fix #3904?

[jennifer-shehane]

Was trying to fix if this PR fixes an issue, but running into this error and the tests don't run.

[vineetbrikl]

Hi,
Is the issue with before/after hook rerun on superdomain navigation resolved? It was mentioned in #1987 that it has been released with version 4.8.0. I tried in both 6.6.0 and 4.8.0 I am still able to reproduce. There seems to be multiple PRs regarding this issue but there's not clear information about it was actually fixed or not. Could you please confirm when this is going to get fixed?