Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Cypress object proxying related code for certain utils #7486

Merged
merged 8 commits into from
May 27, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented May 26, 2020

thought this could be cleaned up, I think this makes things easier to reason about and easier to find the code you're looking for

happy to discuss

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 26, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@brian-mann brian-mann self-requested a review May 26, 2020 19:53
brian-mann
brian-mann previously approved these changes May 26, 2020
@cypress
Copy link

cypress bot commented May 26, 2020



Test summary

7427 0 104 0


Run details

Project cypress
Status Passed
Commit 366578e
Started May 27, 2020 5:24 PM
Ended May 27, 2020 5:30 PM
Duration 06:00 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb
Copy link
Contributor Author

kuceb commented May 27, 2020

both failures are flake @brian-mann

@kuceb kuceb requested a review from brian-mann May 27, 2020 17:36
@kuceb kuceb merged commit 50cdd67 into develop May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants