Fix typo that made user projects include bundled typescript. #7072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fixed typo that made user projects include bundled typescript.
Additional details
Why was this change necessary?
This bug made
export default
and import object destruction impossible.What is affected by this change?
We won't import bundled typescript to user projects.
Any implementation details to explain?
Because TypeScript uses duck typing, it cannot detect when an invalid field is added to an object. (It's been discussed since 2014, but it seems that there's no clear answer yet.)
Because of that, I didn't notice that
baseDir
is wrong. (The right name isbasedir
.)I fixed the typo.
Unfortunately, I guess there's no other way to test them except adding some test code to master branch tests.
How has the user experience changed?
The test passes.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?