Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo that made user projects include bundled typescript. #7072

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Apr 20, 2020

User facing changelog

Fixed typo that made user projects include bundled typescript.

Additional details

Why was this change necessary?

This bug made export default and import object destruction impossible.

What is affected by this change?

We won't import bundled typescript to user projects.

Any implementation details to explain?

Because TypeScript uses duck typing, it cannot detect when an invalid field is added to an object. (It's been discussed since 2014, but it seems that there's no clear answer yet.)

Because of that, I didn't notice that baseDir is wrong. (The right name is basedir.)

I fixed the typo.

Unfortunately, I guess there's no other way to test them except adding some test code to master branch tests.

How has the user experience changed?

The test passes.

PR Tasks

  • [NA] Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [NA] Has a PR for user-facing changes been opened in cypress-documentation?
  • [NA] Have API changes been updated in the type definitions?
  • [NA] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 20, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@sainthkh
Copy link
Contributor Author

Flaky performance test failures.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually confirmed that this fixes the issue in #7036 when typescript is not a dependency of the project.

I would like some test to cover this.

@jennifer-shehane
Copy link
Member

We can add a test to our example-recipes or another example repo that will run whenever a PR is merged into develop. @bahmutov mentioned would add something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import a function throws type error exception
2 participants