-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TypeScript always transpile modules to CommonJS style #7166
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Flaky tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and fixes the original problem, nice.
I think the only thing it needs is a test in packages/server/test/e2e with a corresponding TS project in packages/server/.projects (tsconfig.json
with some weird module
setting)
I tried this branch against #7043 and it is also resolved |
User facing changelog
Cypress ignore typescript module configuration in tsconfig file and transpile code to only CommonJS style.
Additional details
Why was this change necessary?
TypeScript can transpile modules in different styles. But node can only execute CommonJS style.
What is affected by this change?
N/A
Any implementation details to explain?
I added this option to
run_plugins.js
for similar cases.How has the user experience changed?
N/A
About testing
Like #7072, it should be tested on the master branch.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?