-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CommonJS module format when transpiling TS code #7197
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may want to allow for more options for folks to specify which tsconfig
file they want to use explicitly, and/or whether transpileOnly
is true. But for now I'm 👍 on this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I found only a minor error. 👍
Co-authored-by: Kukhyeon Heo <sainthkh@naver.com>
@tgriesser can you rereview and approve? i accepted one change from @sainthkh that caused your review to be dismissed |
User facing changelog
Default TypeScript options now set
module: commonJS
which Node and the browser expect. Before this PR user could setmodule: nextjs
in theirtsconfig.json
and nothing would work if you hadimport
orasync
keywords in the source code.How has the user experience changed?
Previously failing projects should work.
PR Tasks