This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Fix unshelved instance failing to get fixed ip #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdosborn
commented
Mar 29, 2018
| celery_logger.exception("Neutron did not accept request - %s." | ||
| % bad_request.message) | ||
| if 'no fixed ip' in bad_request.message.lower(): | ||
| fixed_ip = add_fixed_ip(driverCls, provider, identity, |
There was a problem hiding this comment.
Only necessary change was to replace this call to add_fixed_ip, I couldn't overlook how incredibly hacky this all was, and got rid of it.
This was probably a failed attempt to fix the bug fixed in this pr.
|
I tested this against an unshelved instance that was in the wrong availability zone on the IU provider, which is where the bug was first observed. |
cdosborn
force-pushed
the
fix-fail-to-add-ip-on-unshelve
branch
from
cb38f2b
to
4d6b413
Compare
|
I like the approach here iff we're continuing to remove fixed IP addresses from instances when we shelve (and suspend, etc.) them. |
cdosborn
force-pushed
the
fix-fail-to-add-ip-on-unshelve
branch
from
4d6b413
to
5130640
Compare
I changed the name of add_fixed_ip, because we are taking a quite different approach here. We delete all an instance's ports, and then instruct nova to attach the instance to a subnet. Nova takes care of creating a port. This fixes an outstanding issue in nova[0]. Our original approach is to keep ports around and then just update the fixed ips. However, when an instance and its port are created, they each have an availability zone, when we unshelve an instance its AZ may change. If it does change, openstack fails to update the device owner AZ of the port and attaching a fixed ip fails because no ports exist in the AZ. We also used to exit from add_fixed_ip if the instance already had a fixed ip. However, we can no longer do this. Instances affected by this shelving bug, will never have their fixed ips removed, so if we exited early. Instances that need a new port (on the new AZ) would not receive a new port. https://bugs.launchpad.net/nova/+bug/1759924[0]
|
We are still removing the fixed ips. However, instances affected by the nova bug will actually fail to remove the fixed ips, and restore_port compensates for that. |
cdosborn
force-pushed
the
fix-fail-to-add-ip-on-unshelve
branch
from
5130640
to
af002eb
Compare
|
My base branch was off, there is only a single commit. |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
On unshelve instances would sometimes fail to get a fixed ip
Solution
Rather than update ip on current port, delete all ports and create a new one
I changed the name of add_fixed_ip, because we are taking a quite different approach here. We delete all an instance's ports, and then instruct nova to attach the instance to a subnet. Nova takes care of creating a port.
This fixes an outstanding issue in nova[0]. Prior to this change we kept ports around and then removed/added fixed ips. However, when an instance and its port are created, they each have an availability zone(AZ), when we unshelve an instance its AZ may change. If it does change, openstack fails to update the device owner AZ of the port and attaching a fixed ip fails because no ports exist in the AZ.
https://bugs.launchpad.net/nova/+bug/1759924 [0]
Checklist before merging Pull Requests