This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Bring in the latest from v31 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the name of add_fixed_ip, because we are taking a quite different approach here. We delete all an instance's ports, and then instruct nova to attach the instance to a subnet. Nova takes care of creating a port. This fixes an outstanding issue in nova[0]. Our original approach is to keep ports around and then just update the fixed ips. However, when an instance and its port are created, they each have an availability zone, when we unshelve an instance its AZ may change. If it does change, openstack fails to update the device owner AZ of the port and attaching a fixed ip fails because no ports exist in the AZ. We also used to exit from add_fixed_ip if the instance already had a fixed ip. However, we can no longer do this. Instances affected by this shelving bug, will never have their fixed ips removed, so if we exited early. Instances that need a new port (on the new AZ) would not receive a new port. https://bugs.launchpad.net/nova/+bug/1759924[0]
…shelve Fix unshelved instance failing to get fixed ip
|
I'm going to make sure this builds, then ill push it to master, so an unnecessary merge isn't made. |
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr #599 was brought into v31, and thus v31 needs to now be brought into master
Checklist before merging Pull Requests