This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Upgrade chromogenic to fix imaging cleaning issue #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imaging would occasionally fail in the cleaning phase with:
"UnboundLocalError: local variable properties referenced before assignment"
Here is the explanation from the chromogenic project (77841b08114d7193ea432b214edd57be74906a0d):
When an instance is imaged, a snapshot is made of the instance, then that
snapshot is mounted locally so that the filesystem can be cleaned. Then that
cleaned image is then uploaded as the image, which will appear in atmosphere.
When chromogenic images, it actually checks if a snapshot has been made before
and just uses that rather than always creating a snapshot.
Just prior to uploading chromogenic looks up the snapshot image (what it calls
the parent image), and uses properties on it for the final image. The bug was
that looking up the snapshot would return None sometimes, which would cause
the properties lookup to fail.
Chromogenic would first populate the cache, when it checked if the snapshot
had ever been created. Then it would create the snapshot (never updating the
cache) then would later ask if the cache had the snapshot.
So the error can be reliably reproduced, if you delete the snapshot before you
retry imaging.
cdosborn
force-pushed
the
chromogenic-0.4.18
branch
from
b3184ec
to
85203f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Imaging would occasionally fail in the cleaning phase with:
"UnboundLocalError: local variable properties referenced before assignment"
See cyverse/chromogenic#7
Checklist before merging Pull Requests