Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Upgrade chromogenic to fix imaging cleaning issue #619

Merged
merged 2 commits into from
May 22, 2018

Commits on May 18, 2018

  1. Upgrade chromogenic to fix imaging cleaning issue

    Imaging would occasionally fail in the cleaning phase with:
    "UnboundLocalError: local variable properties referenced before assignment"
    
    Here is the explanation from the chromogenic project (77841b08114d7193ea432b214edd57be74906a0d):
    
        When an instance is imaged, a snapshot is made of the instance, then that
        snapshot is mounted locally so that the filesystem can be cleaned. Then that
        cleaned image is then uploaded as the image, which will appear in atmosphere.
    
        When chromogenic images, it actually checks if a snapshot has been made before
        and just uses that rather than always creating a snapshot.
    
        Just prior to uploading chromogenic looks up the snapshot image (what it calls
        the parent image), and uses properties on it for the final image. The bug was
        that looking up the snapshot would return None sometimes, which would cause
        the properties lookup to fail.
    
        Chromogenic would first populate the cache, when it checked if the snapshot
        had ever been created. Then it would create the snapshot (never updating the
        cache) then would later ask if the cache had the snapshot.
    
        So the error can be reliably reproduced, if you delete the snapshot before you
        retry imaging.
    cdosborn committed May 18, 2018
    Configuration menu
    Copy the full SHA
    2d15930 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85203f9 View commit details
    Browse the repository at this point in the history