Add simple dever json validation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eywords conflict with pre-defined keys
# Conflicts: # bin/configuration/handleComponents.js
+ Removed console message when project cannot be found. As this should not be part of the config handler
+ Added new simple implementation of dever.json validate command + Created constant helper to have a central location for predefined keys
…removed from dever_config.json
#27 Ensure project keywords does not conflict with pre-defined keys
…ponents are not empty
#5 Add confirmation to dever init
…t been created yet
…t been created yet
#5 Add confirmation to dever init
…d on npm update
#4 Moved location config file to user folder to avoid it being cleared by npm update
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added simple dever.json validation which initially will only check for correctly formatted JSON and that pre-defined keys are not being used as keywords
Issue ticket number and link
Initial implementation of new functionality for validating dever.json at location or by passing file path location
Checklist before requesting a review
✔️ I have read and followed guidelines for contributing to this repository
✔️ I have performed a self-review of my code
✔️ I have made sure to create a pull request from a topic/feature/bugfix branch
✔️ I have followed the commit's or even all commits' message styles matches our requested structure.