Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greatest, least, greatestIndex and leastIndex ignore nulls #209

Closed
wants to merge 2 commits into from
Closed

greatest, least, greatestIndex and leastIndex ignore nulls #209

wants to merge 2 commits into from

Conversation

Fil
Copy link
Member

@Fil Fil commented Jun 3, 2021 •
edited
Loading

@Fil Fil requested a review from mbostock June 3, 2021 16:15
mbostock
mbostock requested changes Jun 3, 2021
View reviewed changes
src/greatest.js Outdated Show resolved Hide resolved
@Fil Fil requested a review from mbostock June 3, 2021 20:09
@mbostock mbostock mentioned this pull request Jun 3, 2021
Merged
@mbostock
Copy link
Member

mbostock commented Jun 5, 2021

Superseded by #210.

@mbostock mbostock closed this Jun 5, 2021
@mbostock mbostock deleted the least-ignore-null branch August 14, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

least and greatest should ignore nulls
2 participants
@Fil @mbostock