Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t consider null comparable. #210

Merged
merged 4 commits into from
Jun 5, 2021
Merged

Don’t consider null comparable. #210

merged 4 commits into from
Jun 5, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jun 3, 2021

Alternative to #209.

@mbostock mbostock requested a review from Fil June 3, 2021 20:20
Fil
Fil approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes! you went to the root :)

@mbostock
Copy link
Member Author

mbostock commented Jun 5, 2021

I will do this as part of d3-array@3.

@mbostock mbostock mentioned this pull request Jun 5, 2021
Closed
@mbostock mbostock merged commit 7c1123e into main Jun 5, 2021
@mbostock mbostock deleted the mbostock/null-comparable branch June 5, 2021 15:32
@Fil Fil mentioned this pull request Jun 23, 2021
Closed
@mbostock mbostock mentioned this pull request Jul 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil