Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnv-controlfreec-tumor-only.tsv.gz status field capitalized but other CNV files lowercase #557

Open
jharenza opened this issue Mar 9, 2024 · 2 comments
Labels
bug Something isn't working completed v16

Comments

@jharenza
Copy link
Member

jharenza commented Mar 9, 2024

What data file(s) does this issue pertain to?

cnv-controlfreec-tumor-only.tsv.gz

What release are you using?

v13-v15

Put your question or report your issue here.

The status column in the freec tumor only cnv file has capitalized values but the values in the t/n files are all lowercase. This will cause an issue in all modules which use a case-sensitive status, as well as the pedcbio load, so should be updated and release modules rerun.

> table(freec_tumor_only$status)

   Gain    Loss Neutral 
 158089   63256  120994 

> table(freec$status)

   gain    loss neutral 
2159530  923876  577559 
@jharenza jharenza added the bug Something isn't working label Mar 9, 2024
@jharenza
Copy link
Member Author

jharenza commented Mar 9, 2024

The CNV files for tumor only were merged in the hope project, but the original files (eg) have lowercase status. It is unclear where the caps came from. We can ask @zhangb1's team to do a new merge for this cohort.

Furthermore, this file as well as snv-mutect2-tumor-only-plus-hotspots.maf.tsv.gz seem to contain all hope samples, instead of the intended tumor only samples.

@jharenza
Copy link
Member Author

jharenza commented Jul 7, 2024

Noting here, I think we may also need to assign amplification and deep deletion to freec calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed v16
Projects
None yet
Development

No branches or pull requests

1 participant