-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outline #13
Merged
Update outline #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also closes #11 |
ewafula
reviewed
Jun 5, 2023
@ewafula thanks for the comments, ready for re-review! |
ewafula
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @jharenza, for updating. Now looks good to me.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
[ci skip] This build is based on 5278431. This commit was created by the following CI build and job: https://github.com/d3b-center/OpenPedCan-methods/commit/527843103fed7b9995af732485d22bd3b8f72fea/checks https://github.com/d3b-center/OpenPedCan-methods/actions/runs/5180718168
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
[ci skip] This build is based on 5278431. This commit was created by the following CI build and job: https://github.com/d3b-center/OpenPedCan-methods/commit/527843103fed7b9995af732485d22bd3b8f72fea/checks https://github.com/d3b-center/OpenPedCan-methods/actions/runs/5180718168
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the outline and adds a few repository references to the methods
UPDATE: I also added many files which were part of the OpenPBTA manuscript repo, esp CI files and CONTRIBUTING, updated links to be specific to this repo, and added in the README links to the PDF and HTML webpage. I also pulled over the author list from the OpenPBTA repo - not in any particular order, and not inclusive.
Closes #6
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
I was trying to figure out how to get Appveyor Bot to comment on the PR after checks, but couldn't figure it out.
Is the pull request ready for review?
yes
Pull review checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.
Spellcheck Step
The dictionary used for spellchecking can be updated.
Edit the file in
build/assets/custom-dictionary.txt
by adding new entries to the end.You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within
build/assets
on your favorite OS X or Linux machine: