Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outline #13

Merged
merged 13 commits into from
Jun 5, 2023
Merged

Update outline #13

merged 13 commits into from
Jun 5, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Jun 4, 2023

Purpose

This PR updates the outline and adds a few repository references to the methods

UPDATE: I also added many files which were part of the OpenPBTA manuscript repo, esp CI files and CONTRIBUTING, updated links to be specific to this repo, and added in the README links to the PDF and HTML webpage. I also pulled over the author list from the OpenPBTA repo - not in any particular order, and not inclusive.

Closes #6

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

I was trying to figure out how to get Appveyor Bot to comment on the PR after checks, but couldn't figure it out.

Is the pull request ready for review?

yes

Pull review checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

Spellcheck Step

The dictionary used for spellchecking can be updated.
Edit the file in build/assets/custom-dictionary.txt by adding new entries to the end.
You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within build/assets on your favorite OS X or Linux machine:

(( len = $(awk '!a[$0]++' < custom-dictionary.txt | wc -l ) - 1 )); tmpfile="$(mktemp)"; echo "personal_ws-1.1 en $len utf-8" > $tmpfile; tail -n +2 custom-dictionary.txt | awk '!a[$0]++' >> $tmpfile; mv $tmpfile custom-dictionary.txt

@jharenza jharenza requested a review from ewafula June 4, 2023 17:44
@jharenza jharenza changed the title WIP: update outline Update outline Jun 4, 2023
@jharenza jharenza requested a review from zzgeng June 4, 2023 17:44
@jharenza
Copy link
Member Author

jharenza commented Jun 5, 2023

Also closes #11

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
README.md Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
content/metadata.yaml Outdated Show resolved Hide resolved
content/metadata.yaml Outdated Show resolved Hide resolved
@jharenza jharenza requested a review from ewafula June 5, 2023 16:41
@jharenza
Copy link
Member Author

jharenza commented Jun 5, 2023

@ewafula thanks for the comments, ready for re-review!

Copy link
Contributor

@ewafula ewafula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @jharenza, for updating. Now looks good to me.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the outline of the methods section
2 participants