Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author hilldd #38

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Add author hilldd #38

merged 4 commits into from
Jun 16, 2023

Conversation

atlas4213
Copy link
Contributor

Purpose

Added in authorship for Dave Hill
Briefly describe your changes here.
Added authorship

Issue

What GitHub issue does your pull request address?
Added authorship

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

metadata.yaml

Is there anything that you want to discuss further?

No

Is the pull request ready for review?

Yes

Pull review checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

Spellcheck Step

The dictionary used for spellchecking can be updated.
Edit the file in build/assets/custom-dictionary.txt by adding new entries to the end.
You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within build/assets on your favorite OS X or Linux machine:

(( len = $(awk '!a[$0]++' < custom-dictionary.txt | wc -l ) - 1 )); tmpfile="$(mktemp)"; echo "personal_ws-1.1 en $len utf-8" > $tmpfile; tail -n +2 custom-dictionary.txt | awk '!a[$0]++' >> $tmpfile; mv $tmpfile custom-dictionary.txt

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atlas4213 the author details look good, but you might have not been on the main branch when you created your branch, as I see some diffs here in the methods as well. Can you revert the methods file or pull the current methods file from main and put it in this branch so that there are no diffs? (or open a clean PR)

@jharenza jharenza self-requested a review June 16, 2023 14:27
@jharenza jharenza merged commit e23cca4 into d3b-center:main Jun 16, 2023
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants