-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add liftover methods #67
Conversation
Co-Authored-By: Dan Miller <dmiller15@users.noreply.github.com>
hi @migbro this pr is ready for review when you get a chance :) |
Click the link below to download the manuscript build as a ZIP file. There were 5 spelling errors. |
Click the link below to download the manuscript build as a ZIP file. There were 0 spelling errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update link, should probably update the repo to point at the specific file as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to request changes
@migbro link is updated, thanks! |
Click the link below to download the manuscript build as a ZIP file. There were 0 spelling errors. |
Click the link below to download the manuscript build as a ZIP file. There were 0 spelling errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Click the link below to download the manuscript build as a ZIP file. There were 0 spelling errors. |
[ci skip] This build is based on 3cfcb7b. This commit was created by the following CI build and job: https://github.com/d3b-center/OpenPedCan-methods/commit/3cfcb7b501eafbba82bb84ace8b5dd32bd1e7209/checks https://github.com/d3b-center/OpenPedCan-methods/actions/runs/9290091434
[ci skip] This build is based on 3cfcb7b. This commit was created by the following CI build and job: https://github.com/d3b-center/OpenPedCan-methods/commit/3cfcb7b501eafbba82bb84ace8b5dd32bd1e7209/checks https://github.com/d3b-center/OpenPedCan-methods/actions/runs/9290091434
Purpose
This PR adds gene symbol liftover methods
Issue
Closes #62
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the pull request ready for review?
Pull review checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.
Spellcheck Step
The dictionary used for spellchecking can be updated.
Edit the file in
build/assets/custom-dictionary.txt
by adding new entries to the end.You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within
build/assets
on your favorite OS X or Linux machine: