Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update molecular subtyping methods #86

Merged
merged 13 commits into from
May 29, 2024
Merged

update molecular subtyping methods #86

merged 13 commits into from
May 29, 2024

Conversation

rjcorb
Copy link
Contributor

@rjcorb rjcorb commented May 21, 2024

Purpose

Briefly describe your changes here.

This PR adds updated subtyping methods for the following tumor histologies:

  • Craniopharyngioma
  • Embryonal tumors (non-MB, non-ATRT)
  • Ependymoma
  • High-grade glioma
  • Low-grade glioma
  • Medulloblastoma
  • Pineoblastoma

Issue

What GitHub issue does your pull request address?

#69 - #75

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please review new text and ensure that this matches with respective histology subtyping flow diagrams in OpenPedCan-analysis module.

Is there anything that you want to discuss further?

Is the pull request ready for review?

Yes

Pull review checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

Spellcheck Step

The dictionary used for spellchecking can be updated.
Edit the file in build/assets/custom-dictionary.txt by adding new entries to the end.
You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within build/assets on your favorite OS X or Linux machine:

(( len = $(awk '!a[$0]++' < custom-dictionary.txt | wc -l ) - 1 )); tmpfile="$(mktemp)"; echo "personal_ws-1.1 en $len utf-8" > $tmpfile; tail -n +2 custom-dictionary.txt | awk '!a[$0]++' >> $tmpfile; mv $tmpfile custom-dictionary.txt

@rjcorb rjcorb requested a review from jharenza May 21, 2024 16:34
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e745ecc.

Manuscript build

There were 73 spelling errors.
Check the build link above for details.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes, but will approve pending those

content/06.methods.md Outdated Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
content/06.methods.md Outdated Show resolved Hide resolved
@jharenza
Copy link
Member

73

can you also check these spelling errors and update the dictionary with new words to add, alphabetize, and update wordcount at the top in https://github.com/d3b-center/OpenPedCan-methods/blob/main/build/assets/custom-dictionary.txt - thanks!

rjcorb and others added 7 commits May 29, 2024 09:47
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 905ba74.

Manuscript build

There were 70 spelling errors.
Check the build link above for details.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit c909aa9.

Manuscript build

There were 70 spelling errors.
Check the build link above for details.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e673ffe.

Manuscript build

There were 0 spelling errors.
Check the build link above for details.

@rjcorb rjcorb merged commit 084e977 into main May 29, 2024
1 check passed
@rjcorb rjcorb deleted the rjcorb/69-update-subtyping branch May 29, 2024 14:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants