-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update molecular subtyping methods #86
Conversation
Click the link below to download the manuscript build as a ZIP file. There were 73 spelling errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few changes, but will approve pending those
can you also check these spelling errors and update the dictionary with new words to add, alphabetize, and update wordcount at the top in https://github.com/d3b-center/OpenPedCan-methods/blob/main/build/assets/custom-dictionary.txt - thanks! |
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Click the link below to download the manuscript build as a ZIP file. There were 70 spelling errors. |
Click the link below to download the manuscript build as a ZIP file. There were 70 spelling errors. |
Click the link below to download the manuscript build as a ZIP file. There were 0 spelling errors. |
[ci skip] This build is based on 084e977. This commit was created by the following CI build and job: https://github.com/d3b-center/OpenPedCan-methods/commit/084e9777d4253115341c24d9d908e0715c41b824/checks https://github.com/d3b-center/OpenPedCan-methods/actions/runs/9287993989
[ci skip] This build is based on 084e977. This commit was created by the following CI build and job: https://github.com/d3b-center/OpenPedCan-methods/commit/084e9777d4253115341c24d9d908e0715c41b824/checks https://github.com/d3b-center/OpenPedCan-methods/actions/runs/9287993989
Purpose
Briefly describe your changes here.
This PR adds updated subtyping methods for the following tumor histologies:
Issue
What GitHub issue does your pull request address?
#69 - #75
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please review new text and ensure that this matches with respective histology subtyping flow diagrams in OpenPedCan-analysis module.
Is there anything that you want to discuss further?
Is the pull request ready for review?
Yes
Pull review checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.
Spellcheck Step
The dictionary used for spellchecking can be updated.
Edit the file in
build/assets/custom-dictionary.txt
by adding new entries to the end.You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within
build/assets
on your favorite OS X or Linux machine: