Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ new scrna qc docker #249

Merged
merged 9 commits into from
Jun 13, 2024
Merged

✨ new scrna qc docker #249

merged 9 commits into from
Jun 13, 2024

Conversation

migbro
Copy link
Collaborator

@migbro migbro commented Jun 12, 2024

Description

Based on https://github.com/hbctraining/scRNA-seq_online/blob/master/README.md#installation-requirements, new image for scRNA QC

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@migbro migbro added feature New feature or request bix-dev This issue or pull request is bix-dev work labels Jun 12, 2024
@migbro migbro self-assigned this Jun 12, 2024
Co-authored-by: migbro <migbro@users.noreply.github.com>
@migbro
Copy link
Collaborator Author

migbro commented Jun 12, 2024

As to why I picked such a weird version name, it's to reflect this release of the repo: https://github.com/hbctraining/scRNA-seq_online/releases/tag/scRNAseq

Copy link
Collaborator

@dmiller15 dmiller15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to establish a concrete connection to the software you are referencing in the image name.

README.md Outdated
@@ -82,6 +82,7 @@ gatk|4.beta.6|docker pull pgc-images.sbgenomics.com/d3b-bixu/gatk:4.beta.6
gatk|4.beta.6-tabix|docker pull pgc-images.sbgenomics.com/d3b-bixu/gatk:4.beta.6-tabix
gatk|latest|docker pull pgc-images.sbgenomics.com/d3b-bixu/gatk:latest
gistic|latest|docker pull pgc-images.sbgenomics.com/d3b-bixu/gistic:latest
hbc_scrna_qc|v1.0.0-scrnaseq|docker pull pgc-images.sbgenomics.com/d3b-bixu/hbc_scrna_qc:v1.0.0-scrnaseq
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should just go with version scrnaseq even though that's dumb.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought deviating from semantic versioning would break the GHA. Maybe I over thought that.

hbc_scrna_qc/v1.0.0-scrnaseq/Dockerfile Outdated Show resolved Hide resolved
migbro and others added 2 commits June 12, 2024 15:01
@migbro migbro requested a review from dmiller15 June 12, 2024 19:04
Co-authored-by: migbro <migbro@users.noreply.github.com>
@migbro migbro merged commit 0a1ca39 into master Jun 13, 2024
3 checks passed
@migbro migbro deleted the feature/mb-new-scrna-qc branch June 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants