-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ new scrna qc docker #249
Conversation
Co-authored-by: migbro <migbro@users.noreply.github.com>
As to why I picked such a weird version name, it's to reflect this release of the repo: https://github.com/hbctraining/scRNA-seq_online/releases/tag/scRNAseq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to establish a concrete connection to the software you are referencing in the image name.
README.md
Outdated
@@ -82,6 +82,7 @@ gatk|4.beta.6|docker pull pgc-images.sbgenomics.com/d3b-bixu/gatk:4.beta.6 | |||
gatk|4.beta.6-tabix|docker pull pgc-images.sbgenomics.com/d3b-bixu/gatk:4.beta.6-tabix | |||
gatk|latest|docker pull pgc-images.sbgenomics.com/d3b-bixu/gatk:latest | |||
gistic|latest|docker pull pgc-images.sbgenomics.com/d3b-bixu/gistic:latest | |||
hbc_scrna_qc|v1.0.0-scrnaseq|docker pull pgc-images.sbgenomics.com/d3b-bixu/hbc_scrna_qc:v1.0.0-scrnaseq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should just go with version scrnaseq
even though that's dumb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought deviating from semantic versioning would break the GHA. Maybe I over thought that.
Co-authored-by: Dan Miller <dmiller15@users.noreply.github.com>
Co-authored-by: migbro <migbro@users.noreply.github.com>
Description
Based on https://github.com/hbctraining/scRNA-seq_online/blob/master/README.md#installation-requirements, new image for scRNA QC
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: