Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update annoFuse #252

Merged
merged 2 commits into from
Aug 20, 2024
Merged

🔧 Update annoFuse #252

merged 2 commits into from
Aug 20, 2024

Conversation

migbro
Copy link
Collaborator

@migbro migbro commented Aug 20, 2024

Description

Fixes an issue in which some fusions were listed twice with split annotations. This was due to a bug in that annotation data source. That file was fixed by d3b-center/annoFuseData#12 and repo properly updated for versioning by d3b-center/annoFuseData#13

Fixes # https://d3b.atlassian.net/browse/BIXU-2325

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Fusion NSD3--TRIP12 no longer duplicated in output

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@migbro migbro self-assigned this Aug 20, 2024
@migbro migbro assigned migbro and unassigned migbro Aug 20, 2024
@migbro migbro added bug Something isn't working bix-dev This issue or pull request is bix-dev work labels Aug 20, 2024
Copy link
Collaborator

@dmiller15 dmiller15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the ENV needs an equal sign but 👍

@migbro
Copy link
Collaborator Author

migbro commented Aug 20, 2024

Not sure the ENV needs an equal sign but 👍

I think it might be a newer convention Docker is suggesting - I think I put it there because while building it said something about that being the preferred convention

@migbro migbro merged commit 28195ef into master Aug 20, 2024
3 checks passed
@migbro migbro deleted the feature/mb-update-annofuse branch August 20, 2024 18:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants