Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧬 Lancet padding vaf #12

Merged
merged 3 commits into from
Apr 22, 2020
Merged

🧬 Lancet padding vaf #12

merged 3 commits into from
Apr 22, 2020

Conversation

tkoganti
Copy link
Contributor

@tkoganti tkoganti commented Apr 22, 2020

Added variant allele frequencies plots and updated README for lancet padding analysis

Result plot - results/variant_allele_frequencies.png
Code updated - VAF_plots.ipynb

Ticket here

@tkoganti tkoganti requested a review from migbro April 22, 2020 03:42
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small doc clarification

@@ -21,6 +21,14 @@ Each VCF file run at every padding/window length was used to run consensus(sam
- `results/all_samples_consensus_comparisons` - This file has variant numbers and also annotations/locations of where the missing variants are
- `results/var_comparison.pn`

3. Comparing variant allele frequencies

Variant allele frequencies between different padding values is compared using lancet VCF files. Variant allele frequencies are calculated from the VCF files using (alt allele DP/total DP from tumor sample). Violin plots below show that the VAF do not vary between different padding lengths except for 75-100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"padding and window size combinations"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! resolved in the commit below

@migbro migbro changed the title Lancetpaddingvaf 🧬 Lancet padding vaf Apr 22, 2020
@migbro migbro self-requested a review April 22, 2020 18:08
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the change

@tkoganti tkoganti merged commit e6a10ac into master Apr 22, 2020
@migbro migbro deleted the lancetpaddingvaf branch March 25, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants