Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vep99 #13

Merged
merged 7 commits into from
May 5, 2020
Merged

Vep99 #13

merged 7 commits into from
May 5, 2020

Conversation

tkoganti
Copy link
Contributor

Adding VEP annotation tool with VEP99 version and updating all subWF and WF accordingly.

Repo used - https://github.com/d3b-center/canine-dev

Ticket here - https://github.com/d3b-center/bixu-tracker/issues/602

Example task with VEP run here - https://cavatica.sbgenomics.com/u/d3b-bixu/dev-canine-workflow/tasks/b0aede16-9215-4c93-b2d8-77c527a0273b/

@tkoganti tkoganti requested a review from migbro April 28, 2020 04:20
@tkoganti
Copy link
Contributor Author

Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this works great, but stylistically seems to not quite match our guidelines,

@tkoganti
Copy link
Contributor Author

I might have edited in rabix. Did not mean to, I will change it and commit a new VEP script

@tkoganti
Copy link
Contributor Author

tkoganti commented May 4, 2020

Changed the subWF for lancet and tested here

🔨 removed unused input from mutect2 filter subwf
@migbro migbro self-requested a review May 5, 2020 14:52
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I also removed an unused input from mutect2 filter support, and added the PR template so it can be used in the future

@tkoganti tkoganti merged commit c6b17a1 into master May 5, 2020
@tkoganti
Copy link
Contributor Author

tkoganti commented May 5, 2020

Awesome! Thanks @migbro merged branch with master

@migbro migbro deleted the VEP99 branch March 25, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants