Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README with VEP #14

Merged
merged 1 commit into from
May 13, 2020
Merged

Updating README with VEP #14

merged 1 commit into from
May 13, 2020

Conversation

tkoganti
Copy link
Contributor

@tkoganti tkoganti commented May 13, 2020

Pull Request Template

Description

Updated README with VEP documentation

Fixes # (issue) - Removed snpeff documentation in README

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Only touched README, testing not required

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@tkoganti tkoganti requested a review from migbro May 13, 2020 14:00
@tkoganti
Copy link
Contributor Author

VEP 100 is mostly updates to human data. No upgrade necessary for canine annotations. Release notes here

Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

@tkoganti tkoganti merged commit 3d064ef into master May 13, 2020
@migbro migbro deleted the readme_updates branch March 25, 2022 13:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants