Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dns): mismatched qname matching rules #99

Merged
merged 1 commit into from
May 27, 2023
Merged

fix(dns): mismatched qname matching rules #99

merged 1 commit into from
May 27, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented May 27, 2023 •
edited
Loading

Background

Some qname matching in DNS section does not work unstablely.

Checklist

  • The Pull Request has been fully tested

Full changelog

  • MatcherBuilder implementation used incorrect rule index, which is fixed in this PR.

@mzz2017 mzz2017 changed the title fix: dns mismatched qname matching fix: dns mismatched qname rules May 27, 2023
@mzz2017 mzz2017 changed the title fix: dns mismatched qname rules fix(dns): mismatched qname matching rules May 27, 2023
@piyoki piyoki added the feature label May 27, 2023
@mzz2017 mzz2017 merged commit d9f6fa7 into main May 27, 2023
@mzz2017 mzz2017 deleted the fix_dns_mismatch_qname branch May 27, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyoki piyoki piyoki approved these changes

Assignees

@mzz2017 mzz2017

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzz2017 @piyoki