Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dns): mismatched qname matching rules #99

Merged
merged 1 commit into from
May 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/consts/dns.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const (
DnsRequestOutboundIndex_LogicalAnd DnsRequestOutboundIndex = 0xFF
DnsRequestOutboundIndex_LogicalMask DnsRequestOutboundIndex = 0xFE

DnsRequestOutboundIndex_UserDefinedMax = DnsRequestOutboundIndex_AsIs - 1
DnsRequestOutboundIndex_UserDefinedMax = DnsRequestOutboundIndex_Reject - 1
)

func (i DnsRequestOutboundIndex) String() string {
Expand Down
2 changes: 1 addition & 1 deletion component/dns/request_routing.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (b *RequestMatcherBuilder) addQName(f *config_parser.Function, key string,
}
b.simulatedDomainSet = append(b.simulatedDomainSet, routing.DomainSet{
Key: consts.RoutingDomainKey(key),
RuleIndex: len(b.simulatedDomainSet),
RuleIndex: len(b.rules),
Domains: values,
})
upstreamId, err := b.upstreamToId(upstream.Name)
Expand Down
2 changes: 1 addition & 1 deletion component/dns/response_routing.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (b *ResponseMatcherBuilder) addQName(f *config_parser.Function, key string,
}
b.simulatedDomainSet = append(b.simulatedDomainSet, routing.DomainSet{
Key: consts.RoutingDomainKey(key),
RuleIndex: len(b.simulatedDomainSet),
RuleIndex: len(b.rules),
Domains: values,
})
upstreamId, err := b.upstreamToId(upstream.Name)
Expand Down