Skip to content

Commit

Permalink
Revert "Pin requests < 2.32.0" (#22055)
Browse files Browse the repository at this point in the history
Reverts #21977

Docker has released a new version and requests has yanked the offending
versions so we should be able to remove this pin before our release goes
out this week.

(cherry picked from commit 02d69d9)
  • Loading branch information
jmsanders committed May 23, 2024
1 parent d11bd69 commit aaaa8c5
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,4 @@ grpcio<1.48.1; python_version < '3.10'
sqlalchemy<2.0.0

# Added pendulum pin in later versions
pendulum<3

# 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
requests<2.32.0
pendulum<3
1 change: 0 additions & 1 deletion python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ def get_version() -> str:
"morefs[asynclocal]",
"fsspec<2024.5.0", # morefs incompatibly
"rapidfuzz",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
],
"mypy": ["mypy==1.8.0"],
"pyright": [
Expand Down
1 change: 0 additions & 1 deletion python_modules/libraries/dagster-celery-docker/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def get_version() -> str:
f"dagster-celery{pin}",
f"dagster-graphql{pin}",
"docker",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
],
zip_safe=False,
)
7 changes: 1 addition & 6 deletions python_modules/libraries/dagster-docker/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ def get_version() -> str:
],
packages=find_packages(exclude=["dagster_docker_tests*"]),
python_requires=">=3.8,<3.13",
install_requires=[
f"dagster{pin}",
"docker",
"docker-image-py",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
],
install_requires=[f"dagster{pin}", "docker", "docker-image-py"],
zip_safe=False,
)

0 comments on commit aaaa8c5

Please sign in to comment.