Pin requests < 2.32.0 #21977
Merged
Pin requests < 2.32.0 #21977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we investigate breaking docker tests: https://buildkite.com/dagster/dagster-dagster/builds/83562
alangenfeld
approved these changes
May 20, 2024
python_modules/dagster/setup.py
Outdated
| @@ -96,7 +96,7 @@ def get_version() -> str: | |||
| "python-dateutil", | |||
| "python-dotenv", | |||
| "pytz", | |||
| "requests", | |||
| "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 | |||
There was a problem hiding this comment.
would it be better to put this pin this in dagster-docker instead?
|
psf/requests#6707 is our issue |
|
I'm going to merge now that tests are passing but I want us to aim to revert/fix forward/pin more narrowly before this week's release if possible. |
|
docker/docker-py#3257 and our fix |
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
While we investigate breaking docker tests: https://buildkite.com/dagster/dagster-dagster/builds/83562
jmsanders
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit 3e84f4a.
jmsanders
added a commit
that referenced
this pull request
May 23, 2024
Reverts #21977 Docker has released a new version and requests has yanked the offending versions so we should be able to remove this pin before our release goes out this week.
jmsanders
added a commit
that referenced
this pull request
May 23, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
While we investigate breaking docker tests: https://buildkite.com/dagster/dagster-dagster/builds/83562
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
Reverts dagster-io#21977 Docker has released a new version and requests has yanked the offending versions so we should be able to remove this pin before our release goes out this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we investigate breaking docker tests:
https://buildkite.com/dagster/dagster-dagster/builds/83562