Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kinds parameter to graph_asset #25227

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Oct 11, 2024

Summary

Adds the kinds experimental param to @graph_asset, since we've added it to @asset:

@graph_asset(ins={"asset1": AssetIn()}, kinds={"python"})
def my_graph_asset(asset1) -> None:
    return my_op(asset1)

Test plan

Unit test

@benpankow
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@danielgafni danielgafni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benpankow benpankow merged commit bb898b8 into master Oct 16, 2024
1 check passed
@benpankow benpankow deleted the benpankow/graph-asset-kinds branch October 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants