-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better kind api #129
base: master
Are you sure you want to change the base?
Use better kind api #129
Conversation
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
After talking to @benpankow, he submitted these PRs (dagster-io/dagster#25228 and dagster-io/dagster#25227), which once both are merged and released, will allow us to fully migrate to kinds -- I'll hold on merging this and push changes here once those are merged |
moves from using
**build_kind_tags
tokinds=
wherever possible. Currently seems like Sling and dagstermill are the two exceptions.Tested locally by making sure that the kind tags did what I expected