Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better kind api #129

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use better kind api #129

wants to merge 4 commits into from

Conversation

cnolanminich
Copy link
Contributor

moves from using **build_kind_tags to kinds= wherever possible. Currently seems like Sling and dagstermill are the two exceptions.

Tested locally by making sure that the kind tags did what I expected

Copy link

Your pull request at commit 61b747265fa5fb65ee6bf54732fdace3ca87ea4a is automatically being deployed to Dagster Cloud.

Location Status Link Updated
hooli_data_ingest Building... Oct 11, 2024 at 02:28 PM (UTC)
snowflake_insights Building... Oct 11, 2024 at 02:28 PM (UTC)
batch_enrichment Building... Oct 11, 2024 at 02:28 PM (UTC)
basics Building... Oct 11, 2024 at 02:28 PM (UTC)
data-eng-pipeline Building... Oct 11, 2024 at 02:28 PM (UTC)

Copy link

github-actions bot commented Oct 11, 2024

Your pull request at commit 48943aae4635f2d726bdfa5644b9cf88adac6f8d is automatically being deployed to Dagster Cloud.

Location Status Link Updated
hooli_data_ingest Deploy failed Oct 11, 2024 at 02:42 PM (UTC)
snowflake_insights Deploy failed Oct 11, 2024 at 02:42 PM (UTC)
batch_enrichment Deploy failed Oct 11, 2024 at 02:42 PM (UTC)
basics Deploy failed Oct 11, 2024 at 02:42 PM (UTC)
data-eng-pipeline Deploy failed Oct 11, 2024 at 02:42 PM (UTC)

Copy link

github-actions bot commented Oct 11, 2024

Your pull request at commit d1daaf65c1bd8b0acdfa8dcb1ef02eec7eaff915 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
hooli_data_ingest View in Cloud Oct 11, 2024 at 03:02 PM (UTC)
snowflake_insights View in Cloud Oct 11, 2024 at 03:02 PM (UTC)
batch_enrichment View in Cloud Oct 11, 2024 at 03:02 PM (UTC)
basics View in Cloud Oct 11, 2024 at 03:02 PM (UTC)
data-eng-pipeline View in Cloud Oct 11, 2024 at 03:02 PM (UTC)

@cnolanminich
Copy link
Contributor Author

After talking to @benpankow, he submitted these PRs (dagster-io/dagster#25228 and dagster-io/dagster#25227), which once both are merged and released, will allow us to fully migrate to kinds -- I'll hold on merging this and push changes here once those are merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants