added title text to the Join Us form #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmsmith
suggested changes
Oct 27, 2018
| @@ -10,6 +10,12 @@ const mailchimpHTML = { | |||
| /* Add your own MailChimp form style overrides in your site stylesheet or in this style block. | |||
| We recommend moving this block and the preceding CSS link to the HEAD of your HTML file. */ | |||
| </style> | |||
| <h5 style="text-align: center; padding: 5px; margin: 5px;">Join the Daily Bruin Alumni Network, and stay updated with our launch!</h5> | |||
There was a problem hiding this comment.
We generally try to avoid inline styling in The Bruin, and in this case I'm not sure we need it. How does it look without the style atributes?
There was a problem hiding this comment.
Also, why'd you decide to use an h5 here instead of a larger heading? Since the "Join Us" heading is an h1, I'd maybe go with an h2 or h3.
There was a problem hiding this comment.
With style tags:
Without style tags:
Should I take them out?
There was a problem hiding this comment.
A more zoomed out screenshot, for reference. I tried h2 and h3 and they seemed too big, which is why I used h5. What do you think?
There was a problem hiding this comment.
Yes on the taking style tags out. Let's maybe try an h3 or 4 for the header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added title text to the "Join Us" form as requested in Issue #18