Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added title text to the Join Us form #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added title text to the Join Us form #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pages/join-us.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ const mailchimpHTML = {
/* Add your own MailChimp form style overrides in your site stylesheet or in this style block.
We recommend moving this block and the preceding CSS link to the HEAD of your HTML file. */
</style>
<h5 style="text-align: center; padding: 5px; margin: 5px;">Join the Daily Bruin Alumni Network, and stay updated with our launch!</h5>
Copy link
Contributor

@nathanmsmith nathanmsmith Oct 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to avoid inline styling in The Bruin, and in this case I'm not sure we need it. How does it look without the style atributes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why'd you decide to use an h5 here instead of a larger heading? Since the "Join Us" heading is an h1, I'd maybe go with an h2 or h3.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With style tags:
image
Without style tags:
image

Should I take them out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

A more zoomed out screenshot, for reference. I tried h2 and h3 and they seemed too big, which is why I used h5. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes on the taking style tags out. Let's maybe try an h3 or 4 for the header?

<div style="text-align: center">
<p style="padding: 0; margin: 0;">Please fill out this form to join our alumni association and to help us build our directory. Share the link with your DB friends, too! For additional details, visit <a href="https://alumni.dailybruin.com">alumni.dailybruin.com</a>.</p>
<hr style="padding: 0; margin: 0;>
<p style="padding: 0; margin: 0;"><i>Are you interested in being a Class Captain for your graduating year? Please email Tanner Walters at <a href="mailto:alumni@dailybruin.com">alumni@dailybruin.com</a> to discuss our alumni outreach team!</i></p>
</div>
<div id="mc_embed_signup">
<form action="https://dailybruin.us18.list-manage.com/subscribe/post?u=014c63d44740a2918c9745891&amp;id=3dded81acb" method="post" id="mc-embedded-subscribe-form" name="mc-embedded-subscribe-form" class="validate" target="_blank" novalidate>
<div id="mc_embed_signup_scroll">
Expand Down