-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule epub-type-has-matching-role for Epigraphs #234
Comments
It's more a spec issue, in fact. Currently, At the same time, Ace will report a "best practice" issue when an That said, whether In the meantime, there are several options to work around this issue:
<section>
<div epub:type="epigraph" role="doc-epigraph">
…
</div>
</section |
I'm closing this issue as |
Thanks for the explanation, and the workarounds! |
Any news from the spec front ? |
Not that I know… We need to work on this in the Publishing WG. |
@rdeltour you probably mean the EPUB3 CG? |
No, I meant the Publishing WG, as anything related to DPUB ARIA is supposed to happen there no? |
@laudrain @laudrain since this is ARIA-in-HTML territory, you could also file an issue at https://github.com/w3c/html-aria/. For comparison, I recently filed w3c/html-aria#173 which is the same kind of issue (and received a positive response). |
There isn't any reason why it shouldn't be allowed on I can't make the changes, though. As @pkra has already said, you need to open an issue on that specification. It might be simplest just to comment on his issue that it also is used on After that, you also need to get the validator updated. (Romain sometimes updates ace checking in advance, but we need the code base officially updated and that usually requires the mappings be corrected first.) |
@mattgarrish a new issue is probably better since w3c/html-aria#173 is about role=doc-dedication on aside elements. I'll be happy to help pushing both items forward on the ARIA end. |
D'oh, my brain hasn't warmed up yet. For some reason I thought this was about dedication, too... :) |
This epigragh case is the only one line in the mapping where an epub:type value is mapped to a role value with no element allowed on. |
@laudrain that's not quite correct. Some elements have "any role", in particular blockquote (https://www.w3.org/TR/html-aria/#p-pre-blockquote) which is the example in DPUB ARIA (https://w3c.github.io/dpub-aria/#doc-epigraph). |
I've filed w3c/html-aria#177 |
@pkra I am refering to the document https://idpf.github.io/epub-guides/epub-aria-authoring/ where I see only one line where an epub:type value is mapped to a role value (ni-on empty and different from "No Role") and has an empty cell in column "Elements Allowed On". It is the line for epigraph. I support @mattgarrish comment:
|
And yes in https://w3c.github.io/dpub-aria/, doc-epigraph is said to-have:
So it may be that this was not reported to the mapping in https://idpf.github.io/epub-guides/epub-aria-authoring/ which BTW is uesed by Ace a s a reference. @mattgarrish @rdeltour could this mapping be fixed and Ace also ? |
w3c/html-aria#177 has been fixed. |
@pkra great, thanks ! |
I'm reopening this issue, so that we can fix it in the next Ace version. |
Fixed in Axe and Ace: |
The following snippet brings up an epub-type-has-matching-role error from Ace:
section xmlns="http://www.w3.org/1999/xhtml" class="main-document-section" xmlns:epub="http://www.idpf.org/2007/ops" epub:type="epigraph" role="doc-chapter"
Up until we started using EPUBCheck 4.2.1 this week, I had been putting role="doc-epigraph" on these
section
s. But it looks like that role is supposed to go onblockquote
only? Not sure if this is an Ace or an EPUBCheck error, to be honest.The text was updated successfully, but these errors were encountered: