Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aside element and role doc-dedication #173

Closed
pkra opened this issue Sep 30, 2019 · 3 comments · Fixed by #174
Closed

aside element and role doc-dedication #173

pkra opened this issue Sep 30, 2019 · 3 comments · Fixed by #174
Assignees
@scottaohara

Comments

@pkra
Copy link
Member

pkra commented Sep 30, 2019

Currently, role=doc-dedication is not permitted on an aside element, cf. https://www.w3.org/TR/html-aria/#aside

I'm wondering why this is, especially given how, e.g., role=doc-example is allowed on an aside element.
@pkra
Copy link
Member Author

pkra commented Sep 30, 2019

For the record, I had first posted w3c/aria#918 which was both confused and confusing.

scottaohara added a commit that referenced this issue Sep 30, 2019
@scottaohara
add doc-dedication to aside dpub allowances
c306325 
closes #173

adds `doc-dedication` as an allowed dpub role for the `aside` element.

Additional source code cleanup and changing various element links to respec syntax.
@scottaohara scottaohara mentioned this issue Sep 30, 2019
Merged
@scottaohara
Copy link
Member

hey again @pkra ;)

seems quite reasonable that this'd be allowed, so PR has been made. Thanks

@scottaohara scottaohara self-assigned this Sep 30, 2019
@pkra
Copy link
Member Author

pkra commented Sep 30, 2019

Thanks, @scottaohara! And thank you for making a PR.

Sorry again for the confusion on my end.

@pkra pkra mentioned this issue Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottaohara scottaohara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add doc-dedication to aside dpub allowances w3c/html-aria
2 participants
@pkra @scottaohara