Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change setup() function usage to <script setup> in Vue components #1260

Open
13 tasks
mvandenburgh opened this issue Sep 1, 2022 · 0 comments
Open
13 tasks

Change setup() function usage to <script setup> in Vue components #1260

mvandenburgh opened this issue Sep 1, 2022 · 0 comments
Assignees
@mvandenburgh
Labels
client Pertains to the web client DX Affects developer experience maintenance Action to maintain the system (neither a bugfix nor an enhancement) refactor Code refactoring zen task Simple and pleasant tasks to improve the codebase

Comments

@mvandenburgh
Copy link
Member

mvandenburgh commented Sep 1, 2022 •
edited by waxlamp
Loading

Now that we're using Vue 2.7 as of #1258, usage of setup() should be updated to <script setup>, which is now considered best practice in Vue.

Here's a list of files that should be converted:

  • components/CopyText.vue
  • components/DLP/AccessInformationTab.vue
  • components/DLP/AssetSummaryTab.vue
  • components/DLP/ContributorsTab.vue
  • components/DLP/RelatedResourcesTab.vue
  • components/DLP/SubjectMatterTab.vue
  • components/DandiFooter.vue
  • components/DandisetList.vue
  • components/DandisetSearchField.vue
  • components/UserStatusBanner.vue
  • views/DandisetLandingView/DandisetMain.vue
  • views/DandisetLandingView/DandisetSidebar.vue
  • views/DandisetLandingView/ShareDialog.vue
@mvandenburgh mvandenburgh added DX Affects developer experience client Pertains to the web client labels Sep 1, 2022
@mvandenburgh mvandenburgh self-assigned this Sep 1, 2022
@mvandenburgh mvandenburgh mentioned this issue Sep 2, 2022
Merged
@waxlamp waxlamp added refactor Code refactoring zen task Simple and pleasant tasks to improve the codebase labels Mar 2, 2023
@waxlamp waxlamp added the maintenance Action to maintain the system (neither a bugfix nor an enhancement) label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvandenburgh mvandenburgh

Labels
client Pertains to the web client DX Affects developer experience maintenance Action to maintain the system (neither a bugfix nor an enhancement) refactor Code refactoring zen task Simple and pleasant tasks to improve the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waxlamp @mvandenburgh