Upgrade frontend to Vue 2.7 #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`vue-tsc` is aware of `$vuetify` in templates.
jjnesbitt
requested changes
Aug 31, 2022
This was referenced Sep 1, 2022
Closed
Replace `vue-type-check` with `vue-tsc`
mvandenburgh
added
maintenance
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the frontend to Vue 2.7, which includes the composition API natively. Crucially, this allows us to abandon usage of the vue composition API plugin, which will be going EOL at the end of this year. There's also been some major bugs found in that plugin, so I think it makes sense to do this upgrade before diving into some of the console errors and reactivity bugs we've been seeing in the frontend to at least rule it out as the source.
There's other stuff we can and should do at some point, like switching to
<script setup>syntax and using vite instead of webpack, since presumably that will ease the burden when we upgrade to Vue 3 someday. But for now, this is the bear minimum needed to move to Vue 2.7.Closes #1189. Requires #1259 to be merged into this branch first.