Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some vue components to <script setup> #1263

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

mvandenburgh
Copy link
Member

Converts several vue components to <script setup>.

Partly addresses #1260

The enhanced type checking `script setup` provides detected this
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvandenburgh mvandenburgh merged commit 198ae50 into master Sep 2, 2022
@mvandenburgh mvandenburgh deleted the script-setup-conversions branch September 2, 2022 19:59
@dandibot
Copy link
Member

dandibot commented Sep 8, 2022

🚀 PR was released in v0.2.46 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants