Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write design docs for internal and external audit functionality #525

Closed
waxlamp opened this issue Sep 21, 2021 · 4 comments · Fixed by #1801
Closed

Write design docs for internal and external audit functionality #525

waxlamp opened this issue Sep 21, 2021 · 4 comments · Fixed by #1801
Assignees
@waxlamp
Labels
audit design-doc Involves creating or discussing a design document released This issue/pull request has been released.

Comments

@waxlamp
Copy link
Member

waxlamp commented Sep 21, 2021 •
edited
Loading

In addition to a design for the audit system as a whole, it should include specifics on the following features:

  • external
    • who made what changes (create/add/delete/modify/publish/change ownership - includes data and metadata - even better includes known apps such as web ui, cli )
  • internal
    • how many blobs not associated with assets (or delta between total blob size and repo size)
    • how much to garbage collect
    • uploaders by week
    • API requests by origin
    • data or metadata last accessed by dandiset
    • number of assets not accessed in a given time delta
@waxlamp
Copy link
Member Author

waxlamp commented Sep 21, 2021

@satra, I want to fill in the issue description with some basic information. What is meant by "internal" and "external" in this context? Is it just a matter of which changes/actions are allowed to be read about by any user, vs. stuff we wish to keep only to admins? What are some examples?

@satra
Copy link
Member

satra commented Sep 23, 2021 •
edited
Loading

examples:

external:

  • who made what changes (create/add/delete/modify/publish/change ownership - includes data and metadata - even better includes known apps such as web ui, cli )

internal

  • how many blobs not associated with assets (or delta between total blob size and repo size)
  • how much to garbage collect
  • uploaders by week
  • API requests by origin
  • data or metadata last accessed by dandiset
  • number of assets not accessed in a given time delta

@yarikoptic yarikoptic mentioned this issue Oct 7, 2021
Closed
@waxlamp waxlamp added the design-doc Involves creating or discussing a design document label Dec 31, 2021
waxlamp pushed a commit that referenced this issue Jan 7, 2022
@dchiquito
Merge pull request #525 from dandi/django-file-browser
337c8a8 
Handle DJANGO_API when rendering the correct file browser
@danlamanna danlamanna mentioned this issue Sep 6, 2022
Open
@waxlamp waxlamp self-assigned this Mar 8, 2023
@yarikoptic yarikoptic mentioned this issue Mar 28, 2023
Open
@yarikoptic
Copy link
Member

another action which might better have a dedicated ID for that action -- change of the embargo_status. ref: dandi/backups2datalad#8

@yarikoptic yarikoptic mentioned this issue Dec 14, 2023
Closed
@waxlamp waxlamp mentioned this issue Feb 5, 2024
Merged
@dandibot
Copy link
Member

🚀 Issue was released in v0.3.77 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waxlamp waxlamp

Labels
audit design-doc Involves creating or discussing a design document released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Design doc for Audit MVP dandi/dandi-archive
4 participants
@yarikoptic @satra @waxlamp @dandibot